Repository navigation
Fix n8n scanner lint failures for 0.2.2 - #5
Merged
Merged
Conversation
The official scanner (@n8n/scan-community-package) uses plugin 0.40.0 and ignores eslint-disable comments. Move InputError throws out of catch blocks, prefer httpRequest in the credential test with a legacy fallback, and rename the Custom API Call operation to "Make". Local source and tarball scans now pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
0.2.1 published cleanly from GitHub Actions with provenance, but
npx @n8n/scan-community-package n8n-nodes-batchdata@0.2.1failed. The official scanner uses@n8n/eslint-plugin-community-nodes0.40.0 and setsallowInlineConfig: false, so the eslint-disable comments thatn8n-node lintaccepted were ignored.Changes
InputErrorthrows out ofcatchblocks incatalogEngine.ts.helpers.httpRequestand falls back to the legacy helper (the only oneICredentialTestFunctionstypings expose).n8n-node lint, build, and all 40 tests passed. A local run of the official scanner's source and tarball lint also passed.After merge, tag
0.2.2to publish with provenance and replace 0.2.1 as latest.